Make StoreLoader more robust on Windows - #2292
Open
pmcelhaney wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR primarily improves StoreLoader’s file watching behavior to better handle Windows-specific filesystem watcher quirks (notably around creation/rename patterns), while also applying formatting-only TypeScript type-layout changes across several generator/runtime type files.
Changes:
- Adjust
StoreLoaderto poll and to reconcile store presence/loads when events come in via non-canonical temporary paths. - Add a reconcile-on-ready step to close the initial load→watch race window.
- Apply formatting-only updates to several TypeScript type assertions and union/mapped types.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/typescript-generator/operation-type-coder.ts | Formatting-only change to a type assertion for readability/consistency. |
| src/typescript-generator/operation-coder.ts | Formatting-only change to a type assertion for readability/consistency. |
| src/typescript-generator/jsdoc.ts | Formatting-only change to an examples type assertion for readability/consistency. |
| src/typescript-generator/coder.ts | Formatting-only reflow of a constructor type-cast instantiation. |
| src/server/store-loader.ts | Updates watcher configuration and event handling to better detect store file transitions on Windows (incl. temp-path events). |
| src/server/registry.ts | Formatting-only change to an index signature union type. |
| src/counterfact-types/omit-all.ts | Formatting-only change to a mapped type with key remapping. |
| src/counterfact-types/middleware.ts | Formatting-only change to a union type layout. |
Comment on lines
+76
to
79
| // This is a single shallow directory, so polling is inexpensive and | ||
| // avoids platform-specific native watcher limits and missed adds. | ||
| usePolling: true, | ||
| awaitWriteFinish: { pollInterval: 10, stabilityThreshold: 50 }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.