UntilTag should stop on the first tag greater than the requested tag - #268
Open
jpambrun wants to merge 2 commits into
Open
UntilTag should stop on the first tag greater than the requested tag#268jpambrun wants to merge 2 commits into
jpambrun wants to merge 2 commits into
Conversation
Ragnar-Oock
reviewed
Jul 10, 2025
There was a problem hiding this comment.
Is there no way to make this PR work without updating tooling? It might impact unexpected parts of the code.
Collaborator
Author
There was a problem hiding this comment.
It's been a while, but, if I remember correctly, the build was just not working for me.
Otherwise, the tooling changes should not be needed.
Collaborator
Author
There was a problem hiding this comment.
The commit message "Update webpack so it build on modern node" support my memory.
MichaelLeeHobbs
added a commit
to MichaelLeeHobbs/dicomParser
that referenced
this pull request
Jul 23, 2026
…pixel data Phase 1 PR 3/5. Adds the discriminated-union element model (value | sequence | encapsulated | unknown, upstream cornerstonejs#257/cornerstonejs#278), a frame-stack tokenizer with no recursion and bounded loops (mission-critical standard; maxDepth guard), structural delimiter consumption (cornerstonejs#244/cornerstonejs#143) with delimitation items always treated as zero-length (cornerstonejs#266), CP-246 UN undefined-length sequences, cornerstonejs#114 private implicit policy (never peek private defined-length elements), stopAt with >= semantics (cornerstonejs#104/cornerstonejs#268/#52), typed errors with partial-result salvage (#46/cornerstonejs#203/cornerstonejs#277), and the encapsulated pixel-data scanner (BOT + fragments). Ports readSequenceItemsExplicit/Implicit tests and the sequence/UN halves of readDicomElementExplicit/Implicit tests; adds delimiter-pathology, stopAt, truncation-salvage and depth-bound coverage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DSSLWZvjSRByQP3KsghQcJ
MichaelLeeHobbs
added a commit
to MichaelLeeHobbs/dicomParser
that referenced
this pull request
Jul 23, 2026
…pixel data (#5) Phase 1 PR 3/5. Adds the discriminated-union element model (value | sequence | encapsulated | unknown, upstream cornerstonejs#257/cornerstonejs#278), a frame-stack tokenizer with no recursion and bounded loops (mission-critical standard; maxDepth guard), structural delimiter consumption (cornerstonejs#244/cornerstonejs#143) with delimitation items always treated as zero-length (cornerstonejs#266), CP-246 UN undefined-length sequences, cornerstonejs#114 private implicit policy (never peek private defined-length elements), stopAt with >= semantics (cornerstonejs#104/cornerstonejs#268/#52), typed errors with partial-result salvage (#46/cornerstonejs#203/cornerstonejs#277), and the encapsulated pixel-data scanner (BOT + fragments). Ports readSequenceItemsExplicit/Implicit tests and the sequence/UN halves of readDicomElementExplicit/Implicit tests; adds delimiter-pathology, stopAt, truncation-salvage and depth-bound coverage. Claude-Session: https://claude.ai/code/session_01DSSLWZvjSRByQP3KsghQcJ Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DICOM tags are sorted in order in a dicom file. The expectation with untilTag is that parsing will stop as soon as any tag greater then the requested tag is met. This makes it possbiel to parse file parially, say to omit the group 6000 and pixel data, without knowing the presence of a given tag.
Fixes #104
This was only superficially tested.