feat(PlanarFreeHandRoiTool) : implementing PlanarFreeHandRoiTool on oblique plane - #2619
Closed
Celian-abd wants to merge 3 commits into
Closed
feat(PlanarFreeHandRoiTool) : implementing PlanarFreeHandRoiTool on oblique plane#2619Celian-abd wants to merge 3 commits into
Celian-abd wants to merge 3 commits into
Conversation
…to planarfreehand-oblique
6 tasks
Member
|
Thank you for this groundwork on removing the oblique-plane restriction; #2744 builds directly on this implementation and additionally corrects the stats sampling for oblique MPR viewports, so we are consolidating review there. Credit for the approach originates here. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Right now, if we try to draw an annotation using the PlanarFreeHandRoiTool on a non orthogonal plane, it will show the following error : 'No support yet for oblique plane planar contours'.
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment