Skip to content

test(hub): delete tests that pin implementation - #831

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-12132-delete-hub-tests
Nov 4, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-12132-delete-hub-tests

Conversation

@TheGreatAxios

@TheGreatAxios TheGreatAxios commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Deletes hub tests that pin implementation details or past patches: retry ladders, backoff, timers, claim internals, log lines, exact wording and one-off migrations.
  • Deletes duplicates and tests that assert behaviour the stabilization audit found buggy, such as closed pull requests being ignored.
  • Keeps one test per security or sign-in guarantee (rate limits, tenant isolation, grants, webhook signatures, token scoping) and the route contracts the portal relies on that nothing else covers. Exports left unused by the deletions lose their export.

Verification

  • Removed: 362 tests (18 files deleted outright); kept: 173 in apps/hub
  • Job times, before (main merge_group run 41917736251) → after (this PR's CI run 41923165967): postgres 1/3: 108 s → 28 s, postgres 2/3: 49 s → 118 s, postgres 3/3: 123 s → 73 s (postgres total 280 s → 219 s; shards rebalance by file); unit 1/3: 47 s → 61 s, unit 2/3: 146 s → 46 s, unit 3/3: 71 s → 138 s (unit total 264 s → 245 s)
  • bun run check, bun run lint, and the hub unit tests (103 pass) and Postgres tests (70 pass) run locally

Part of CL-12132.

@linear-code

linear-code Bot commented Nov 4, 2026

Copy link
Copy Markdown

CL-12132

@TheGreatAxios
TheGreatAxios force-pushed the cl-12132-delete-hub-tests branch 2 times, most recently from 043eda2 to de07ba2 Compare November 4, 2026 22:53
@TheGreatAxios
TheGreatAxios marked this pull request as ready for review November 4, 2026 22:59

@corbits-triage corbits-triage Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triage requests changes:

  • Merge conflicts: merge conflicts with base

@TheGreatAxios
TheGreatAxios force-pushed the cl-12132-delete-hub-tests branch from c277da7 to f296199 Compare November 4, 2026 23:18
@corbits-triage

corbits-triage Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Merged before Triage finished on f296199.

@TheGreatAxios
TheGreatAxios merged commit 18209f3 into main Nov 4, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant