Repository navigation
fix(judge): carry the rules output as a mail attachment - #812
Merged
TheGreatAxios merged 3 commits intoNov 4, 2026
Merged
TheGreatAxios merged 3 commits into
TheGreatAxios merged 3 commits into
Conversation
TheGreatAxios
marked this pull request as ready for review
November 3, 2026 19:26
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Notes:
|
TheGreatAxios
deleted the
cl-12014-handle-1-mib-rules-payloads-in-triage-judge-without-failing
branch
November 4, 2026 04:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CL-12014
On a pull request whose rules output is over 1 MiB, the judge failed every step with "the mail carries no request", including the report and the stop, so the manager waited for the judge until its deadline. Stock stores a mail part over 1 MiB by reference and leaves out its text, and the judge read only the text.
What changed
rules.jsonattachment.onTriggerbody, because stock reads attachments only for a top-level agent step. Its first step, whose director makes no model call, replies with the attachment for the steps after it, within the judge's 15-minute step timeout.reportandstopread only the body, so the judge reports and stops however the rest ended.report.test.tsis removed: the judge's workflow test covers judgeRequest, report and stop end to end.docs/ARCHITECTURE.mddescribes the judge's mail. The user manual describes nothing that changed.Verified
runLocal, with the rules director given the attachment. A new case shows a judge mailed without the rules reports "the judge did not finish" and stops.bun run check,bun run lint,tests/model, the triage-judge and triage-manager tests and the vendor-diff gate pass.