Repository navigation
refactor(policy): name saved rules by host - #608
Merged
TheGreatAxios merged 1 commit intoOct 25, 2026
Merged
TheGreatAxios merged 1 commit into
TheGreatAxios merged 1 commit into
Conversation
checkPackName takes the repository's host; a Bitbucket Data Center repository's saved rules are titled check-pack/bitbucket-datacenter/<owner>/<name>. Callers that don't know the host yet keep the GitHub title.
TheGreatAxios
force-pushed
the
cl-11463-keep-rules-policy-files-and-stats-separate-for-same-named-s1
branch
from
October 25, 2026 20:00
b62c724 to
10a518e
Compare
TheGreatAxios
marked this pull request as ready for review
October 25, 2026 20:26
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of CL-11463
What changed
checkPackName(repo, source)takes the repository's host, which is now required. A GitHub repository's saved rules keep the titlecheck-pack/<owner>/<name>, and a Bitbucket Data Center repository's becomecheck-pack/bitbucket-datacenter/<owner>/<name>.policy.checkPack.nameand the hub's saved-rules read now pass the record's host. The GitHub title fallback still passes"github"and keeps excluding ids that a same-named record on another host pins, because Bitbucket rules saved before this change keep the GitHub-style title and are read through their pin.writeCheckPack,withPackPointers,saveRepoSettings,hasPack, fake hub) pass"github". That keeps today's behaviour; a later part passes the host.@corbits/artifacts0.2.0,reviseArtifactVersion) applies a giventitle, so a legacy Bitbucket rule set is retitled the next time it is saved with its host.Verification
bun run checkandbun run lintpass.server.test.ts'sbeforeAlltimed out on two runs and passed 12/12 on the third.