Repository navigation
refactor(policy): remove stored workspace policies - #607
Merged
Merged
Conversation
TheGreatAxios
force-pushed
the
cl-11467-remove-stored-workspace-policies
branch
2 times, most recently
from
October 25, 2026 19:24
116ed99 to
44c5042
Compare
TheGreatAxios
marked this pull request as ready for review
October 25, 2026 19:24
Contributor
|
Triage: Unsure Asking a maintainer about:
Notes:
Changed since the last verdict (Fail at |
TheGreatAxios
force-pushed
the
cl-11467-remove-stored-workspace-policies
branch
2 times, most recently
from
October 25, 2026 21:21
dd2cda9 to
b7619b0
Compare
TheGreatAxios
force-pushed
the
cl-11467-remove-stored-workspace-policies
branch
2 times, most recently
from
October 26, 2026 04:38
3c0eddd to
88488ec
Compare
TheGreatAxios
force-pushed
the
cl-11467-remove-stored-workspace-policies
branch
from
October 27, 2026 04:08
88488ec to
0e6ba2a
Compare
TheGreatAxios
marked this pull request as draft
October 27, 2026 04:08
TheGreatAxios
marked this pull request as ready for review
October 27, 2026 04:18
corbits-triage
Bot
dismissed
their stale review
October 27, 2026 04:40
Nothing triage asked to change still fails, so this request no longer stands.
A policy's extends now names only a repository; a stored repository policy that extends anything reads as corrupt.
TheGreatAxios
force-pushed
the
cl-11467-remove-stored-workspace-policies
branch
from
October 27, 2026 04:47
0e6ba2a to
e1eebae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
workspace-policy/<name>artifacts a stored repository policy extended by id):sharedPolicySchema,WORKSPACE_POLICY_TITLE_PREFIX,storedPolicyPack,PolicySource.shared(contracts, triage comment header, hub responses, portal), the hub's shared-policy resolution andpolicy_shared_resolvedlog, the audit log's workspace-policy entries, the admin grant backfill's workspace-policy titles, the portal'sExtendedPolicyError,sharedPolicyin/api/integrations/pack-schema,sharedin both mirror tool schemas, andexportPolicyFile'sextendedparameter.extendsaccepts only a repository (owner/name, or BitbucketPROJECT/slug), using the same pattern as a policy'srepo, in the policy file schema and the override schema, so the validator,/policy/validate, the extension and the Action refuse anything else. A stored repository policy withextendsreads as corrupt: "Only a policy file can extend another repository's policy."extendedFilePack,resolvePolicy,policy.source.sharedFile)..corbits-triage.ymland extending another repository's file.workspace-policy/*artifacts and 0 stored repository policies withextends, so nothing migrates.Verification
bun run checkandbun run lintpass.extends: art_123in a policy file being refused, with and withoutrules, in friendly wording; the workspace-policy export row and save test are deleted; the hub store test is rewritten (pin, unknown checks, archived, config, and a stored policy withextendsreads as corrupt). On current main:bun --conditions=intx-src test packages/triage-contracts packages/triage-workflows apps/hub/src/github apps/web/src/lib1056 pass, 0 fail (Postgres tests included); web DOM tests 8 pass, 0 fail.git grep -n -i "workspace.policy\|workspace-policy\|sharedPolicy\|storedPolicyPack"outside vendor/ matches only the keptSharedPolicyandreadSharedPolicy, which the repository-file path uses.Closes CL-11467