Repository navigation
fix(tooling): fail the vendor drift gate on a deleted vendored file - #600
Merged
TheGreatAxios merged 1 commit intoOct 25, 2026
Conversation
TheGreatAxios
force-pushed
the
cl-11456-fail-the-vendor-drift-gate-when-a-stock-file-is-deleted
branch
from
October 25, 2026 14:34
5ba77f5 to
b374830
Compare
TheGreatAxios
changed the base branch from
cl-11422-match-the-vendor-drift-gate-on-exact-paths
to
main
October 25, 2026 14:34
TheGreatAxios
force-pushed
the
cl-11456-fail-the-vendor-drift-gate-when-a-stock-file-is-deleted
branch
2 times, most recently
from
October 25, 2026 15:07
95b029f to
cafbe88
Compare
TheGreatAxios
force-pushed
the
cl-11456-fail-the-vendor-drift-gate-when-a-stock-file-is-deleted
branch
from
October 25, 2026 15:22
cafbe88 to
50caf08
Compare
TheGreatAxios
marked this pull request as ready for review
October 25, 2026 15:27
Contributor
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. Triage will approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
tooling/vendor-diff-pruned.txt: only the upstream paths a re-vendor excludes, 46 entries (32 directory prefixes, 14 exact files where the parent directory is partly vendored), generated once from the current diff as the shortest ancestor of each missing stock path that holds nothing vendored.tooling/vendor-diff-check.sh:vendor/interchangestays informational only when it, or a directory above it, is listed. Any other missing path fails withD <path>, unless exactly allowlisted like any other drift.covers vendored <path>: <entry>), or covers no missing stock path, such as a directory written without its trailing/(covers no missing stock path: <entry>). These failures get their own advice: remove or narrow the entry.vendor/interchange/VENDORED.md: absent upstream paths are informational only when listed in the pruned list, and a re-vendor whose excluded paths change updates it. The file is excluded from the gate.docs/ARCHITECTURE.md(Vendoring) describes the list.Verification
Against the pinned stock commit, fetched from upstream:
informational: 5125 upstream paths are absent from the pruned checkout.packages/hub-client/entry: exit 1,covers vendored …lines andcovers no missing stock path: packages/hub-client/.tests/workflow/written astests/workflow): exit 1, the files under it fail asD, andcovers no missing stock path: tests/workflow.packages/hub-client/src/transforms.tsdeleted and committed: exit 1,D packages/hub-client/src/transforms.ts.Closes CL-11456