fix(hooks): keep a hook's broken pipe from crashing the run - #994
Merged
Conversation
The payload was written to a lifecycle hook's stdin without awaiting the write. A shell hook that handles one lifecycle kind exits at once on the other, closing its end of the pipe; a run summary larger than the pipe buffers, as a long session's is, then fails with EPIPE, and the unhandled rejection took the process down at the end of a finished run. The write is awaited, a broken pipe is recorded as the hook's outcome, and the run ends as it did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postTurnis dispatched apostRunsummary larger than the pipe buffers; no unhandled rejection, no hook error logged, exit status recorded. Fails on the unfixed runner, passes on the fixed one, ten runs out of ten.Verification
bun run typecheck,bun run build, andbun run lintpassbun run testdoes not complete on this machine onorigin/maineither: Bun 1.3.13 segfaults partway through the suite (panic: Segmentation fault at address 0x5, SIGTRAP) with or without this branch.bun test src/session/hooks.test.tspasses.corbits execrun whose hook handled onlypostTurn: the final summary printed, thenEPIPE: broken pipe, sendas an unhandled rejection, exit 1,run.jsonleft atrunning.Fixes #993