Skip to content

Mark bundled plugin rows with a mountain in listings - #976

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-6888-bundled-plugin-marker
Sep 13, 2026
Merged

Mark bundled plugin rows with a mountain in listings#976
TheGreatAxios merged 2 commits into
mainfrom
cl-6888-bundled-plugin-marker

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Plugin and skill rows from bundled origin repo plugins carry a mountain marker in the slash popup and the plugins listing
  • Rows from other origins carry their origin label instead, while built-in rows stay unmarked

Verification

  • bun run check passes (lint, typecheck, build, guarded test suite: 7143 pass, 0 fail)
  • Marker paint and format behavior is covered by unit tests for both surfaces

Fixes CL-6888

@linear-code

linear-code Bot commented Sep 13, 2026

Copy link
Copy Markdown

CL-6888

@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Audit: NEEDS-WORK (AGENTS.md no-emoji marker)

Finding: BUNDLED_PLUGIN_MARKER = "⛰" (U+26F0) violates AGENTS.md ("No emojis in code or docs"). Beyond the rule, terminal width tables disagree on whether U+26F0 measures 1 or 2 cells wide, and the "marked row formats to exactly the target width" test is self-consistent — it measures with the repo's own stringWidth — so it cannot catch a real-terminal misalignment. Fix: switch to the ASCII [bundled], consistent with the existing [user] / [project] / [path] origin labels. I will push this fix to this branch.

Confirmed (no change requested):

  • getCommand → listing equivalence: getCommand and listCommands (src/tui/commands/registry.ts) resolve the winner with the same find-first-active scan over pluginCandidates, so the marked row in listings is the same command dispatch runs.
  • Filtering is unaffected (the marker lives only in the label; match runs on id/keywords), and row-width accounting holds through stringWidth.

1 similar comment
@TheGreatAxios

Copy link
Copy Markdown
Collaborator Author

Audit: NEEDS-WORK (AGENTS.md no-emoji marker)

Finding: BUNDLED_PLUGIN_MARKER = "⛰" (U+26F0) violates AGENTS.md ("No emojis in code or docs"). Beyond the rule, terminal width tables disagree on whether U+26F0 measures 1 or 2 cells wide, and the "marked row formats to exactly the target width" test is self-consistent — it measures with the repo's own stringWidth — so it cannot catch a real-terminal misalignment. Fix: switch to the ASCII [bundled], consistent with the existing [user] / [project] / [path] origin labels. I will push this fix to this branch.

Confirmed (no change requested):

  • getCommand → listing equivalence: getCommand and listCommands (src/tui/commands/registry.ts) resolve the winner with the same find-first-active scan over pluginCandidates, so the marked row in listings is the same command dispatch runs.
  • Filtering is unaffected (the marker lives only in the label; match runs on id/keywords), and row-width accounting holds through stringWidth.

AGENTS.md bans emoji in code, and wide-glyph width tables disagree across terminals on U+26F0, so rows use [bundled] like the other origin labels.
@TheGreatAxios
TheGreatAxios force-pushed the cl-6888-bundled-plugin-marker branch from 9fd2123 to ab48675 Compare September 13, 2026 06:10
@TheGreatAxios
TheGreatAxios merged commit dc46ba8 into main Sep 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant