Skip to content

refactor(auth): trim dead usage formatters and demo - #1031

Merged
TheGreatAxios merged 2 commits into
mainfrom
cl-6815-delete-unreachable-feature-code-kept-alive-only-by-its-own
Sep 15, 2026
Merged

TheGreatAxios merged 2 commits into
mainfrom
cl-6815-delete-unreachable-feature-code-kept-alive-only-by-its-own

Conversation

@TheGreatAxios

Copy link
Copy Markdown
Collaborator

Summary

  • Trims dead Codex/xAI fetch and format helpers, keeping only the live auth-header functions
  • Deletes the unreachable TUI demo, workflow kickoff stub, and their tests
  • Renames usage modules to auth-headers with updated imports

Verification

  • bun run check passes (lint, typecheck, build, guarded suite: 7457 pass / 0 fail)
  • Targeted auth tests pass via oauth-scope-check suite

Fixes CL-6815

@linear-code

linear-code Bot commented Sep 14, 2026

Copy link
Copy Markdown

CL-6815

Decision: usage display is not a product surface — delete fetch/format helpers and their tests rather than wiring them in. Keep only the live auth-header helpers used by oauth-scope-check, renamed usage.ts -> auth-headers.ts. Delete src/tui/demo.ts (410 lines, README-only reference) and the unreferenced workflows/kickoff stub. Net-negative.
@TheGreatAxios
TheGreatAxios force-pushed the cl-6815-delete-unreachable-feature-code-kept-alive-only-by-its-own branch from 9219671 to 51129b6 Compare September 14, 2026 17:54
* chore: clean post-purge stale references

* fix(auth): omit empty account id and pin auth header boundaries (#1064)
@TheGreatAxios
TheGreatAxios merged commit 1128ed7 into main Sep 15, 2026
13 checks passed
TheGreatAxios added a commit that referenced this pull request Sep 15, 2026
fetchCodexUsage/fetchCodexModels/fetchXaiUsage deleted by #1031;
four completion-harness fixtures loaded by path from script.json.
TheGreatAxios added a commit that referenced this pull request Sep 15, 2026
…1042)

* feat(chat): replace onTasksChange/onActivateTools with reactor events

Hosts subscribe to custom.chat.tasks.changed and custom.chat.tools.activate
on the agent stream; TUI repaints the task panel, exec activates tools.

Fixes CL-7916

* refactor(chat): share reactor event-subscriber helper across sinks (#1054)

Extract the duplicated tasks-changed/tools-activate subscriber blocks into handleChatDirectorEvent, log invalid payloads at debug level instead of dropping them silently, and clear queued task-change notifications when a turn throws.

* chore(deadcode): drop stale usage allowlist, cover eval fixtures

fetchCodexUsage/fetchCodexModels/fetchXaiUsage deleted by #1031;
four completion-harness fixtures loaded by path from script.json.

* chore(deadcode): update keeper test for post-trim allowlist

The CL-6815 trim removed the three usage-formatter exports; the scoped
exemption keeper now pins the two remaining constants flags plus the
negative sibling probe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant