[12.0][REM] dependency to beesdoo_product#304
Open
victor-champonnois wants to merge 1 commit into
Open
Conversation
victor-champonnois
requested review from
carmenbianca,
huguesdk,
remytms and
robinkeunen
victor-champonnois
changed the title
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 12.0 #304 +/- ##
=======================================
Coverage 69.98% 69.98%
=======================================
Files 153 153
Lines 2012 2012
Branches 366 366
=======================================
Hits 1408 1408
- Misses 565 566 +1
+ Partials 39 38 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
robinkeunen
approved these changes
Jul 31, 2023
robinkeunen
left a comment
robinkeunen
left a comment
Member
There was a problem hiding this comment.
Pas vu de dépendance dans le code ni dans les vues 👍
huguesdk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module website_sale_detailed_product_description depends on beesdoo_product, which is deprecated. Besides I don't see any dependency to the modules that were splitted from beesdoo_product.
We need to remove this dependency to safely uninstall beesdoo_product from databases.