Repository navigation
fix: 🐛 String codable decoding upgrade - #26
Merged
Merged
Conversation
- Bump SDK constraint to >=3.13.0, equatable to 3.0.0, meta to 1.19.0 and coolint to 3.0.0 - Migrate every constructor to the primary constructor syntax (const new()) - Move analysis options to coolint dart.yaml and exclude the example - Extend Codec serializer type and use Equatable as mixin
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
===========================================
+ Coverage 82.29% 97.11% +14.81%
===========================================
Files 13 13
Lines 209 208 -1
===========================================
+ Hits 172 202 +30
+ Misses 37 6 -31 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Mithos5r
changed the title
Use type patterns in a new _jsonKind helper so the argument message is stable in obfuscated and minified release builds, where runtimeType of user-defined types is not contractually preserved. Add bool and double scalar cases to the bytes deserialization tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fix non-ascii decoding in JsonStringCodable and add a decoding benchmark
✅ Type of Change
Please check the box that applies to your pull request.
✔️ Checklist
Please make sure you have completed the following tasks before submitting your pull request: