Remove temporary tool preview feature flag - #88
Draft
gandhipratik203 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Pratik Gandhi <gandhipratik203@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the temporary
VITE_ENABLE_TOOL_PREVIEWflag and makes the Tools details drawer always render theTry it/Definitiontab layout.Changes:
Try itImportMetaEnvblockContext
Blocker
This PR is intentionally draft-only until the backend preview endpoint lands.
Removing the flag flips the production/default image path from Try-it hidden to Try-it visible. Since
/rpcexists but/tools/preview/{name}does not until IBM/mcp-context-forge#5629 lands, the post-removal production state would expose gated live invoke beside a Preview button that 404s.The current docker e2e gateway image is
ghcr.io/ibm/mcp-context-forge:v1.0.8, which predates the preview endpoint.Un-draft Gate
docker-compose.e2e.ymlis bumped to the firstghcr.io/ibm/mcp-context-forgerelease containingPOST /tools/preview/{name}.npm run e2e:dockerpasses against that image.Tests
git grep -n "VITE_ENABLE_TOOL_PREVIEW\|isToolPreviewEnabled" -- .- no tracked matchesnpm run lintnpm run format:check./node_modules/.bin/tsc -bnpm run testnpm run buildPLAYWRIGHT_SKIP_WEBSERVER=1 PLAYWRIGHT_BASE_URL=http://127.0.0.1:5173 npm run e2e -- e2e/tools.spec.ts -g "previews a tool|live invokes|confirms destructive|cancellation|tools.execute|servers.use|federated|denied passthrough"git diff --checkNot Run
npm run e2e:docker- blocked until the pinned gateway image contains [FEATURE][API]: Add tool preview endpoint for safe invocation dry-run IBM/mcp-context-forge#5629.Manual Verification
Pending real-backend verification. The UI can now expose the default Try-it tab without setting
VITE_ENABLE_TOOL_PREVIEW, but the real Preview action must not be signed off until the backend endpoint exists in the tested gateway image.