Skip to content

Remove temporary tool preview feature flag - #88

Draft
gandhipratik203 wants to merge 1 commit into
mainfrom
feat/6322-remove-tool-preview-flag
Draft

Remove temporary tool preview feature flag#88
gandhipratik203 wants to merge 1 commit into
mainfrom
feat/6322-remove-tool-preview-flag

Conversation

@gandhipratik203

Copy link
Copy Markdown
Contributor

Summary

This removes the temporary VITE_ENABLE_TOOL_PREVIEW flag and makes the Tools details drawer always render the Try it / Definition tab layout.

Changes:

  • remove the tool-preview feature helper
  • always open Tools details on Try it
  • remove test env stubs and the obsolete false-flag test
  • remove Playwright, Dockerfile, and docker-compose.e2e flag wiring
  • remove the now-empty ImportMetaEnv block

Context

Blocker

This PR is intentionally draft-only until the backend preview endpoint lands.

Removing the flag flips the production/default image path from Try-it hidden to Try-it visible. Since /rpc exists but /tools/preview/{name} does not until IBM/mcp-context-forge#5629 lands, the post-removal production state would expose gated live invoke beside a Preview button that 404s.

The current docker e2e gateway image is ghcr.io/ibm/mcp-context-forge:v1.0.8, which predates the preview endpoint.

Un-draft Gate

Tests

  • git grep -n "VITE_ENABLE_TOOL_PREVIEW\|isToolPreviewEnabled" -- . - no tracked matches
  • npm run lint
  • npm run format:check
  • ./node_modules/.bin/tsc -b
  • npm run test
  • npm run build
  • PLAYWRIGHT_SKIP_WEBSERVER=1 PLAYWRIGHT_BASE_URL=http://127.0.0.1:5173 npm run e2e -- e2e/tools.spec.ts -g "previews a tool|live invokes|confirms destructive|cancellation|tools.execute|servers.use|federated|denied passthrough"
  • git diff --check

Not Run

Manual Verification

Pending real-backend verification. The UI can now expose the default Try-it tab without setting VITE_ENABLE_TOOL_PREVIEW, but the real Preview action must not be signed off until the backend endpoint exists in the tested gateway image.

Signed-off-by: Pratik Gandhi <gandhipratik203@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove temporary tool preview feature flag after backend preview endpoint lands

1 participant