fix(ui): row color adjustment for component tables - #58
Open
a-effort wants to merge 1 commit into
Open
Conversation
a-effort
changed the title
Reverts the light/dark hover and selected steps added in 8a07588 during PR #47. The steps sat below the contrast threshold, so they read as a selection cue without being one — the details drawer remains the affordance for which row is open. Drops the comment that framed the flat fill as an accessibility gap. Signed-off-by: Anna Effort <anna.effort@ibm.com>
a-effort
force-pushed
the
ui/restore-flat-table-row-fill
branch
from
August 20, 2026 18:45
c085ab6 to
09b0741
Compare
a-effort
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts the hover/selected fill steps that
8a07588added to the three drawer tables during #47, restoring the flat fill from that PR's first commit:ToolsTable.tsx,ResourcesTable.tsx,PromptDefinitionTable.tsx— base, hover and selected allbg-neutral-50/dark:bg-neutral-800/50.data-state="selected"stays on the row for tests and any future affordance.PromptDefinitionTabledocblock line that framed the flat fill as an accessibility gap.Why
8a07588landed as a contrast fix. Measured, the steps fail two SCs.1.4.11 non-text contrast — a state indicator needs 3:1 against what it's distinguished from. Neither step is close, so neither reads as a state:
1.4.3 text contrast — the URI and ID columns are
text-xs text-muted-foreground, so they need 4.5:1. The selected fill is dark enough to push them under:neutral-50neutral-200neutral-800/50neutral-700So the selected fill traded a cue below the perceptibility threshold for body text below AA — a net accessibility regression in both themes. On the flat fill, which row is open is carried by the details rail, and keyboard position by the focus ring.
Ratios are WCAG 2.x, computed from the resolved tokens in
src/index.css(--popover,--foreground,--muted-foreground) with the/50and/60alphas composited over the drawer body.Follow-up, not in this PR
Rows keep their click and keyboard handlers here. Making them inert and moving the affordances onto the row's own controls is #59.
--ringagainst the row fill is 2.48:1 in light, 3.48:1 in dark. Light is below the 3:1 that 1.4.11 and 2.4.11 want of a focus indicator, and since the flat fill leans on the ring for keyboard state, it's worth fixing — but--ringis global, so it's its own change.Selection is still not exposed to assistive tech (no
gridrole, noaria-selected) on any of the three tables. Also pre-existing, also cross-cutting.Testing
84 tests across the three table suites pass;
tsc,eslint,prettierclean. No e2e run.