fix(google-docs): add file type guidance copy to main page [INTEG-3887]#10976
Open
Franco Banfi (FBanfi) wants to merge 3 commits into
Open
fix(google-docs): add file type guidance copy to main page [INTEG-3887]#10976Franco Banfi (FBanfi) wants to merge 3 commits into
Franco Banfi (FBanfi) wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR addresses some feedback: when the Google Drive file picker returns
no results, users see a bare "No documents" message with no explanation of why, leaving them confused about whether they're connected to the wrong Drive or simply don't have the right file type.Original plan
The initial approach was to detect the empty state proactively: before opening the picker, but the OAuth token the app holds is scoped to drive.file, a non-sensitive scope that only grants access to files the app itself created or was explicitly handed via the picker. It does not allow listing pre-existing files in the user's Drive. Additionally, the picker UI itself is rendered by Google in its own iframe. We have no control over what it displays internally and receive no "empty results" callback.
Approach
Because of those limitations we:
Testing steps
Added several missing tests for the main page.
Breaking Changes
No
Dependencies and/or References
INTEG-3887
Deployment
No