feat: upgrade full/ package to PG 18, remove deparse + proto.js#154
Merged
Conversation
- Update libpg_query tag from 17-6.1.0 to 18.0.0 - Remove deparse/deparseSync (deparse handled downstream) - Remove proto.js (5.2 MB), @launchql/protobufjs dep, protogen script - Remove wasm_deparse_protobuf, wasm_parse_query_protobuf, wasm_get_protobuf_len from C wrapper - Clean up EXPORTED_FUNCTIONS in Makefile - Update @pgsql/types dep to ^18.0.0 - Update CI matrix full version 17 -> 18 BREAKING CHANGE: deparse() and deparseSync() are no longer exported. Use @pgsql/deparser or equivalent downstream deparse library instead.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the
full/(@libpg-query/parser) package from libpg_query17-6.1.0to18.0.0and removes deparse functionality (handled downstream viapgsql-deparser).Changes:
LIBPG_QUERY_TAG→18.0.0, removed_wasm_deparse_protobuf,_wasm_parse_query_protobuf,_wasm_get_protobuf_lenfromEXPORTED_FUNCTIONSwasm_deparse_protobuf(),wasm_parse_query_protobuf(),wasm_get_protobuf_len()C functionsdeparse(),deparseSync()exports andproto.jsimportproto.jsfrom files, removed@launchql/protobufjsdep and@launchql/proto-clidevDep, removedprotogenscript, updated@pgsql/typesto^18.0.0full/proto.js(5.2 MB),full/scripts/protogen.js,full/test/deparsing.test.jsfull/README.md, updated rootREADME.mdRemaining exports:
parse,parseSync,parsePlPgSQL,parsePlPgSQLSync,fingerprint,fingerprintSync,normalize,normalizeSync,scan,scanSyncBREAKING CHANGE:
deparse()anddeparseSync()are no longer exported.Review & Testing Checklist for Human
@libpg-query/parserrely ondeparse/deparseSync— these are removedparsePlPgSQLwith PG 18's reworked PL/pgSQL parser to confirm behavior matches expectationsNotes
pg_query_parse_plpgsql) is unchanged in PG 18 — the rework is internal to how it processes inputprotobuf/pg_query.pb-c.hinclude is retained in wasm_wrapper.c becausewasm_scan()usespg_query__scan_result__unpackfrom itLink to Devin session: https://app.devin.ai/sessions/5d3588c124524869b388ced885962d70
Requested by: @pyramation