fix: triggerUncaughtException(err, true /* fromPromise */);

[webbrain-one]

Closes #47

[connorads]

Hey, thanks for the PR!

Could you show it working? Log output or a screenshot from a real run would settle it.

Heads up that you'll need an account that hasn't earned Fanatic to reach this branch at all, since if (!awarded) is skipped otherwise. Easiest way is ALTERNATIVE_URL pointed at a Stack Exchange site where you don't have the badge yet.

Two things I'm unsure about:

• The commit message says it wraps the wait so a missing badge doesn't cause an uncaught rejection, but I don't see a try/catch and waitForSelector is unchanged. Wouldn't it still crash the same way?

• Removing page.click('.js-select-badge-container') looks like it breaks this. That selector was #badge-card-settings before SO renamed it (see Track badge progress #9 and Fix css selector that changed on SO side #33), and per SO's own user.en.js the picker contents are AJAX-loaded on click:

  load: function ({container: e, userId: t, ...}) {
    e.data("loaded") || $.get("/users/activity/next-badge-popup?userId=" + t + ...)
      .done(function (t) { e.data("loaded", !0).empty().append(t) })
  }

  So [data-badge-database-name="Fanatic"] isn't in the DOM at all until that click happens, and waitForSelector would time out exactly as in triggerUncaughtException(err, true /* fromPromise */); #47.

Using page.goto instead of clicking .s-user-card is a nice simplification though, we already have userid by that point. Happy to be proven wrong by a run.