Repository navigation
fix: align Kubernetes dependencies and compile E2E tests in CI - #33
dheerajodha merged 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughAdds a GitHub Actions workflow that compiles packages and tests, then dry-runs labeled E2E tests. Updates Kubernetes, controller-runtime, and Prometheus module dependencies. ChangesCompile and E2E dry-run workflow
Module dependency updates
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change aligns Kubernetes dependencies and adds a compile and dry-run workflow. No actionable merge-blocking risk was found; live Konflux execution remains unvalidated, as is normal for this kind of change. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The ITS check in conforma/cli#3574 fails before executing any tests at E2E commit
eb59162d: generated code ink8s.io/api v0.36.5callsvalidate.EachSliceVal, which is unavailable in the selectedk8s.io/apimachinery v0.37.1.Align
api,apiextensions-apiserver, andclient-gotov0.37.1, and use controller-runtimev0.25.0, which targets Kubernetes 0.37. Tekton v1.17.0 already requires apimachinery v0.37.1, so lowering only our direct requirement would not resolve the mismatch. Refresh go.sum and the resulting Prometheus indirect dependencies.Add a read-only GitHub Actions workflow on PRs and main pushes that compiles all packages/tests and dry-runs the E2E suite without cluster credentials. This catches compilation failures before changes merge.
Validation:
go test -mod=readonly ./... -run '^$'.go mod tidy -diff, workflow YAML parsing, andgit diff --checkpass.Live Konflux execution remains to be validated. After merge, conforma/cli#3574 needs both E2E revision pins updated to this fix's upstream commit. Artifact collection permission errors are separate and outside this change.