Skip to content

fix: align Kubernetes dependencies and compile E2E tests in CI - #33

Merged
dheerajodha merged 1 commit into
conforma:mainfrom
dheerajodha:codex/fix-e2e-kubernetes-compatibility
Oct 11, 2026
Merged

dheerajodha merged 1 commit into
conforma:mainfrom
dheerajodha:codex/fix-e2e-kubernetes-compatibility

Conversation

@dheerajodha

Copy link
Copy Markdown
Contributor

The ITS check in conforma/cli#3574 fails before executing any tests at E2E commit eb59162d: generated code in k8s.io/api v0.36.5 calls validate.EachSliceVal, which is unavailable in the selected k8s.io/apimachinery v0.37.1.

Align api, apiextensions-apiserver, and client-go to v0.37.1, and use controller-runtime v0.25.0, which targets Kubernetes 0.37. Tekton v1.17.0 already requires apimachinery v0.37.1, so lowering only our direct requirement would not resolve the mismatch. Refresh go.sum and the resulting Prometheus indirect dependencies.

Add a read-only GitHub Actions workflow on PRs and main pushes that compiles all packages/tests and dry-runs the E2E suite without cluster credentials. This catches compilation failures before changes merge.

Validation:

  • Reproduced the original EachSliceVal compilation failure before the fix.
  • All packages and tests compile with go test -mod=readonly ./... -run '^$'.
  • Linux/AMD64 E2E test binary compiles.
  • Full dry-run discovers all 15 scenarios; ITS-only dry-run selects all three ITS scenarios.
  • go mod tidy -diff, workflow YAML parsing, and git diff --check pass.

Live Konflux execution remains to be validated. After merge, conforma/cli#3574 needs both E2E revision pins updated to this fix's upstream commit. Artifact collection permission errors are separate and outside this change.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: c17d21d4-6220-4c6f-b152-b162832861a4
📥 Commits

Reviewing files that changed from the base of the PR and between eb59162 and b80d7dd.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (2)
  • .github/workflows/compile.yaml
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

Adds a GitHub Actions workflow that compiles packages and tests, then dry-runs labeled E2E tests. Updates Kubernetes, controller-runtime, and Prometheus module dependencies.

Changes

Compile and E2E dry-run workflow

Layer / File(s) Summary
Run compile and E2E checks
.github/workflows/compile.yaml
Adds a workflow for pull requests and pushes to main. It configures Go from go.mod, compiles packages and tests, and dry-runs labeled TestE2E tests. The job has read-only contents permission and a 15-minute timeout.

Module dependency updates

Layer / File(s) Summary
Update module dependency versions
go.mod
Updates Kubernetes API, apiextensions-apiserver, and client-go to v0.37.1; controller-runtime to v0.25.0; client_golang to v1.24.0; and procfs to v0.21.1.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: cuipinghuo, acepresso

Merge Risk: ⚪ Minimal · up to b80d7

The change aligns Kubernetes dependencies and adds a compile and dry-run workflow. No actionable merge-blocking risk was found; live Konflux execution remains unvalidated, as is normal for this kind of change.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the dependency alignment and CI E2E compilation changes.
Description check ✅ Passed The description directly explains the Kubernetes dependency fix, the new CI workflow, and the reported validation results.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@dheerajodha
dheerajodha enabled auto-merge October 9, 2026 11:28
@dheerajodha
dheerajodha merged commit 18ee6ce into conforma:main Oct 11, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants