Skip to content

Track upstream fixes for synced workflow zizmor suppressions #451

Description

@jezdez

Follow-up from #361.

zizmor.yml currently ignores auditor-persona findings for workflows synced from conda/infrastructure because those workflow files should not be changed directly in this repository.

conda/infrastructure#1328 already added baseline zizmor coverage upstream, but it does not enable the auditor persona. Running zizmor 1.25.2 --persona=auditor .github/workflows against current conda/infrastructure origin/main still reports findings for the synced workflows, so the remaining upstream task is specifically the auditor-persona cleanup/suppression work.

Synced workflows currently covered by local suppressions here:

  • .github/workflows/cla.yml
  • .github/workflows/issues.yml
  • .github/workflows/labels.yml
  • .github/workflows/lock.yml
  • .github/workflows/project.yml
  • .github/workflows/stale.yml
  • .github/workflows/update.yml

The ignored findings include permissions, undocumented permissions, concurrency/job naming, secrets-outside-env, superfluous-actions, artipacked, and template-injection findings depending on the workflow.

Tasks:

  • Update conda/infrastructure to run zizmor with the auditor persona, matching this repository's pre-commit configuration.
  • Apply the appropriate fixes upstream in conda/infrastructure, or add upstream-owned zizmor ignore entries where a finding is intentionally accepted.
  • Sync the updated workflows back into this repository.
  • Remove the corresponding ignore entries from zizmor.yml in this repository once the synced workflows no longer need local suppressions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions