Conversation
Signed-off-by: Eric <ericgozzi@cosmicgarage.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a set of improvements to the
frontend/compas_threejsproject, focusing on code quality, maintainability, and type safety. The changes include the addition of Prettier and ESLint for consistent code formatting and linting, refactoring of TypeScript types for stricter type checking, and cleanup of unused code. The update also features formatting improvements in Vue components for better readability.Tooling and Code Quality Enhancements:
.prettierrc,.prettierignore,eslint.config.js) and updatedpackage.jsonscripts and dependencies to support linting and formatting workflows. [1] [2] [3] [4] [5]TypeScript Type Improvements:
unknownorRecord<string, unknown>instead ofanyfor improved type safety, especially in communication and UI management modules (communication.ts,objectInfo.ts,sidebarStore.ts,websocket.ts). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Code Cleanup and Unused Code Removal:
unpackMessageandSCENE_GEOMETRIES, to streamline the codebase. [1] [2] [3]Formatting and Readability Improvements:
ObjectInfo.vue,Openbar.vue) for more concise markup and improved maintainability, and made minor CSS formatting adjustments. [1] [2] [3] [4] [5] [6] [7] [8]Minor Logic Adjustments:
These changes collectively enhance the project's code quality, enforce consistent coding standards, and lay the groundwork for safer and more maintainable TypeScript development.