Repository navigation
set executable flag on mac as well - #65
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a permissions issue that prevented the protoc binary from executing on macOS in GitHub Actions. The executable flag was previously only set on Linux systems, but macOS (Darwin) also requires this permission.
Key Changes:
- Extended platform check to include macOS when setting executable permissions on the protoc binary
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/compas_pb/invocations.py | Modified platform check to include "Darwin" (macOS) alongside "Linux" for setting executable flag |
| CHANGELOG.md | Added entry documenting the fix for protoc permission issues on Mac |
| @@ -22,6 +22,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Changed | |||
|
|
|||
There was a problem hiding this comment.
The changelog entry is placed under the '### Changed' section, but fixes should be documented under a '### Fixed' section according to Keep a Changelog conventions.
Suggested change
| ### Fixed |
Member
Author
There was a problem hiding this comment.
do you see a Fixed section?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating proto files fails on the github action mac machine, I suspect it's due to not setting the binary as executable.