Repository navigation
Conversation
Override react-aria-components, react-aria, react-stately, @react-aria/utils, @react-spectrum/utils and @internationalized/date to the ranges of Aurora's core/catalog.json, in the Volto harness (pnpm.overrides) and the Aurora one (pnpm-workspace.yaml overrides). Both lockfiles now resolve the same versions: react-aria-components 1.21.1, react-aria 3.52.1, react-stately 3.50.0. Volto's lockfile only changes for those libraries. A stopgap until Volto's and Aurora's @plone/components agree on one version by themselves. Refs #132
sneridagh
force-pushed
the
issue-132-phase-5
branch
from
October 4, 2026 15:35
4f9da33 to
9d4e4db
Compare
A Playwright test sends a magic link from Aurora's login page, reads it from Mailpit, and signs in with it, then checks that the same link is refused the second time. The link has to point at Aurora's own address: the backend builds it through the virtual-host URL. The acceptance site has no mail server and no sender address, so the test gives it both, and adds the email provider only for its own run: beside Dex it would stop /login going straight to Dex in the other tests. Mailpit starts with `make acceptance-mail-start`, and in CI. Refs #132
sneridagh
changed the title
The harness's acceptance server now runs the add-on's own pas.plugins.identity.testing.ACCEPTANCE_TESTING layer instead of Volto's robot layer. It already installs collective.MockMailHost and configures a sender, so the test reads the link through the server's Robot Framework remote library, and no mail service or registry patching is needed. The layer's Zope root lacked the virtual host monster, which the Aurora add-on's VirtualHostBase URLs need; the layer now installs it, the way Volto's robot fixture does. Products.PrintingMailHost was considered: it writes mail to the log, which a test could read only by scraping the backend's output. Refs #132
This was referenced Oct 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth phase of #132, stacked on #136. Draft: please don't merge. Each phase gets its own PR, built on the previous one, and none is merged until the whole series has been reviewed.
Two things:
identity-core's components run on React Aria in both frontends. Until Volto's and Aurora's@plone/componentsagree on one version by themselves, the two development harnesses force one.What changes
Both harnesses override the React Aria libraries to the ranges in Aurora's
core/catalog.json. Volto's own catalogue has the same ranges.react-aria-components^1.17.0react-aria^3.48.0react-stately^3.46.0@react-aria/utils^3.34.0@react-spectrum/utils^3.13.0@internationalized/date^3.12.1pnpm.overridesinfrontend/package.json.overridesinfrontend/aurora/pnpm-workspace.yaml.Why the lockfiles changed too
The ranges already matched, but the two lockfiles had been resolved at different times. Volto had
react-aria-components1.20.0,react-aria3.51.0 andreact-stately3.49.0; Aurora had the versions above.Volto's lockfile was moved to Aurora's versions by pinning them for one install and then restoring the ranges. Its diff touches only these libraries and their
@internationalized/number. A plainpnpm updateof the six would also have re-resolved unrelated packages: webpack plugins, and Volto'sreact-is-19alias.Each lockfile has exactly one version of each library, and the transitive
@internationalized/*and@react-types/sharedmatch too.AGENTS.mdgains the rule: keep the two override lists the same, and both lockfiles resolving the same versions.Magic-link acceptance test
frontend/aurora/acceptance/tests/magic-link.spec.ts:/login-identity. This shows the backend built it through the virtual-host URL.The test adds the email provider for its own run and removes it afterwards. Beside Dex, that provider would stop
/logingoing straight to Dex in the sole-provider test.Where the mail comes from
The harness's acceptance server now runs the add-on's own layer,
pas.plugins.identity.testing.ACCEPTANCE_TESTING, instead of Volto'sVOLTO_ROBOT_TESTING. The layer already installscollective.MockMailHostand configures a sender, so every message the site sends is kept, not sent. The test reads the last one through the server's Robot Framework remote library (get_the_last_sent_email, over XML-RPC).Products.PrintingMailHostcollective.MockMailHostOne backend change: the layer's Zope root had no virtual host monster, which the Aurora add-on's
VirtualHostBaseURLs need.testing.pynow installs it, as Volto's robot fixture does. The backend suite passes: 3837 tests.All five acceptance tests pass locally. Not run in CI yet.
Checks
make -C frontend lint,make aurora-lint, both typecheckspnpm build,make aurora-build, Storybook