Repository navigation
Conversation
First phase of #132: move what the Volto add-on can share with a future Aurora add-on into @plone-collective/identity-core, with no behaviour change. - The REST payload types, the vocabulary names and 15 helpers that need no frontend framework move to the new package, with their tests. - A table of every REST path replaces the paths spelled out in the Volto actions. - avatar's colour logic now takes the palette as a parameter; the Volto module only supplies the configured one. expandedProfile stays in the Volto add-on, since it reads Volto's Redux store. - An ESLint override rejects any framework import in identity-core. - The Dockerfile, the root test and typecheck scripts and the contributor docs now include the package.
sneridagh
marked this pull request as draft
October 2, 2026 21:36
sneridagh
marked this pull request as ready for review
October 3, 2026 08:07
Member
Author
|
LGTM, let's continue with the next one, stack them on the top of it |
This was referenced Oct 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First phase of #132. Moves what the Volto add-on can share with a future Aurora add-on into a new package,
@plone-collective/identity-core. Nothing changes for a site.What moved
frontend/packages/identity-core, with their tests:types/api.ts,types/blocks.ts)endpoints, covering every REST path the frontend calls. The Volto actions now build their paths from it. The existing action tests check exact paths and pass unchanged, so the table reproduces every path, including the two that aren't percent-encoded. That is safe forloginProvider: the backend only accepts ids matching^[A-Za-z0-9_-]+$.user(userid)keeps the unencoded path from before; this PR changes no path.avatarwas split. The colour logic is in core and takes the palette as a parameter. The Volto module only suppliesconfig.settings.identity.avatarColors.expandedProfilestays in the Volto add-on, because it reads Volto's Reduxcontentslice.The boundary
An ESLint override in
frontend/.eslintrc.jsrejects any Volto, Aurora, React, Redux, router or i18n import inidentity-core. I checked that it fires: a file in core importingreactand a Volto helper fails lint. Core imports no React, so its source can be shared between two dev setups without bundling two Reacts.Also changed
frontend/Dockerfilecopies the new package; otherwise the image build would fail on theworkspace:*dependency.testandtypecheckscripts run core too. Core's tests use plain vitest and need neither Volto nor Aurora.volto-identitylists core inaddons, so Volto transpiles its TypeScript source. That is also why core default-exports a no-opapplyConfig.AGENTS.mdandcontributing.mdlist the package and its news scope;reference/frontend.mdsource citations were updated.Not covered: release
repoplonepublishes exactly one frontend package, so it cannot releaseidentity-coreyet. This needs settling before the next release, orvolto-identitywill ship depending on a package that isn't on npm. The options are in #132.For integrators: code that imported one of the moved helpers by its
@plone-collective/volto-identity/helpers/...path now imports it from@plone-collective/identity-core. Thevolto-identitynews fragment says so.Checks
make -C frontend lint(ESLint with zero warnings, typecheck for both packages, prettier, stylelint)make docs-buildmake -C docs valepnpm i18nmake check