Repository navigation
Require Django 6.0 and drop deprecated task runners - #211
Merged
Merged
Conversation
* Require Django 6.0 or later * Remove the deprecated Celery and Dramatiq task runners * Remove the deprecated JOEFLOW_CELERY_QUEUE_NAME fallback * Use the MAILERS setting instead of the deprecated EMAIL_BACKEND
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #211 +/- ##
==========================================
+ Coverage 97.61% 98.26% +0.65%
==========================================
Files 19 17 -2
Lines 880 807 -73
==========================================
- Hits 859 793 -66
+ Misses 21 14 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
* Celery, Dramatiq and Redis are no longer documented * jitter and triple are unused
The local worker fixture only forwarded to stub_worker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joeflow still supported Django 5.2 and carried deprecated code that only existed to keep that release working. The Celery and Dramatiq task runners, the
JOEFLOW_CELERY_QUEUE_NAMEfallback, and the version switches were all marked for removal once Django 5.2 LTS support expired. This drops them and moves the minimum supported version to Django 6.0.django>=6.0and drop the Django 5.2 classifier.tasks/machine.py.JOEFLOW_CELERY_QUEUE_NAMEsetting.JOEFLOW_TASK_RUNNERnow always defaults to the Django Tasks runner.MAILERSsetting instead of the deprecatedEMAIL_BACKENDin the test project.fakeredis,redis, andpytest-env.Celery,Dramatiq,Redis,jitterandtripleentries from the spelling wordlist.