Skip to content

feat(bootstrap): add Central otel credentials options#410

Merged
BBesrour merged 7 commits into
mainfrom
bilel/add-central-otel-creds-opts
May 18, 2026
Merged

feat(bootstrap): add Central otel credentials options#410
BBesrour merged 7 commits into
mainfrom
bilel/add-central-otel-creds-opts

Conversation

@BBesrour
Copy link
Copy Markdown
Member

@BBesrour BBesrour commented May 15, 2026

CU-869d79gqh

Adds possibility to pass central otel creds. Need to send traces to central collector (deployed on dc0) so that they are viewable in central grafana.

Related PRs:

@jonas-zipprick
Copy link
Copy Markdown

@BBesrour BBesrour self-assigned this May 15, 2026
Comment thread internal/installer/files/config_yaml.go Outdated
@BBesrour BBesrour force-pushed the bilel/add-central-otel-creds-opts branch from 9d785ca to 0364ff0 Compare May 18, 2026 08:53
@BBesrour BBesrour requested a review from Copilot May 18, 2026 08:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support to pass Central OpenTelemetry (central collector) credentials through the GCP bootstrap flow so traces/spans can be exported to a central collector and viewed in central Grafana.

Changes:

  • Extend install config schema with Monitoring.CentralOtel and add vault secret extraction for its credentials.
  • Add GCP bootstrap CLI flags (--central-otel-username/--central-otel-password) and populate install config when both are provided.
  • Add Ginkgo tests for the GCP bootstrap install-config population behavior and update CLI docs.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
internal/installer/files/config_yaml.go Adds CentralOtel config type/field and writes central otel creds into the vault during secret extraction.
internal/bootstrap/gcp/install_config.go Populates Cluster.Monitoring.CentralOtel from bootstrap inputs when both creds are present.
internal/bootstrap/gcp/install_config_test.go Adds tests covering CentralOtel env var combinations and expected install-config outcome.
internal/bootstrap/gcp/gcp.go Extends bootstrap environment struct with CentralOtel username/password fields.
cli/cmd/bootstrap_gcp.go Adds CLI flags to accept CentralOtel credentials.
docs/oms_beta_bootstrap-gcp.md Documents the new CLI flags in the command reference.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread internal/installer/files/config_yaml.go Outdated
Comment thread internal/installer/files/config_yaml.go
Comment thread internal/installer/files/config_yaml.go Outdated
@BBesrour BBesrour merged commit 8e9ccf9 into main May 18, 2026
5 of 7 checks passed
@BBesrour BBesrour deleted the bilel/add-central-otel-creds-opts branch May 18, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants