feat(bootstrap): add Central otel credentials options#410
Merged
Conversation
NautiluX
approved these changes
May 15, 2026
schrodit
reviewed
May 15, 2026
Signed-off-by: BBesrour <58034472+BBesrour@users.noreply.github.com>
9d785ca to
0364ff0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support to pass Central OpenTelemetry (central collector) credentials through the GCP bootstrap flow so traces/spans can be exported to a central collector and viewed in central Grafana.
Changes:
- Extend install config schema with
Monitoring.CentralOteland add vault secret extraction for its credentials. - Add GCP bootstrap CLI flags (
--central-otel-username/--central-otel-password) and populate install config when both are provided. - Add Ginkgo tests for the GCP bootstrap install-config population behavior and update CLI docs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/installer/files/config_yaml.go | Adds CentralOtel config type/field and writes central otel creds into the vault during secret extraction. |
| internal/bootstrap/gcp/install_config.go | Populates Cluster.Monitoring.CentralOtel from bootstrap inputs when both creds are present. |
| internal/bootstrap/gcp/install_config_test.go | Adds tests covering CentralOtel env var combinations and expected install-config outcome. |
| internal/bootstrap/gcp/gcp.go | Extends bootstrap environment struct with CentralOtel username/password fields. |
| cli/cmd/bootstrap_gcp.go | Adds CLI flags to accept CentralOtel credentials. |
| docs/oms_beta_bootstrap-gcp.md | Documents the new CLI flags in the command reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CU-869d79gqh
Adds possibility to pass central otel creds. Need to send traces to central collector (deployed on dc0) so that they are viewable in central grafana.
Related PRs: