Repository navigation
Conversation
Tapping a masked link now shows the existing leaving-Flipcash warning with the subtitle: "<label>" will open <host>. A bare link keeps the current subtitle. Only the copy changes.
bmc08gt
force-pushed
the
feat/chat-text-format-render
branch
from
October 13, 2026 12:02
e115d7c to
303e8f6
Compare
bmc08gt
force-pushed
the
feat/chat-masked-link-warning
branch
from
October 13, 2026 12:02
ea4de8a to
ad2c0ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tapping a masked link
[label](url)shows the existing "You're Leaving Flipcash" warning with the subtitle“<label>” will open <host>. Never share your Access Key with a website.A bare link keeps today's subtitle. Only the copy changes; the warning is being redesigned separately (Figma page 11230:56).Stacked on #1748, because masked links only exist once that renders them. The base is that PR's branch; retarget to
code/cashafter it merges.ExternalLinkUriHandler.openMasked(label, uri)passes the label toopenWithExternalLinkCheck.buildMentionedTexttakesonMaskedLinkClick;TextBubblesupplies it only when the transcript'sExternalLinkUriHandleris in scope.prompt_description_externalLinkMasked.Tests:
FormattedBubbleTextTestchecks that only the masked link carries a tap listener and that it reports the label and URL.