Skip to content

refactor: compose shared .freshnessNote CSS instead of duplicating it #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hivecommons-hive wants to merge 1 commit into from
Closed

refactor: compose shared .freshnessNote CSS instead of duplicating it #1815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/components/GroupLinkStatus/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ import styles from './styles.module.css';
* data/community-groups.json (set by `npm run check:community-group-links`).
* Surfaces any group whose upstream repository is archived or unreachable so
* that drift is visible on the page, not just in a CI log.
*
* `.freshnessNote`'s style composes it from
* `../PeopleFreshness/styles.module.css` (`composes: freshnessNote from
* '../PeopleFreshness/styles.module.css'`) rather than carrying its own
* identical copy of the rule.
*/
export default function GroupLinkStatus() {
const generatedAt = formatDate(groupsData?.generatedAt);
Expand Down
4 changes: 1 addition & 3 deletions src/components/GroupLinkStatus/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
.freshnessNote {
color: var(--ifm-color-emphasis-700);
font-size: 0.85rem;
margin: -0.5rem 0 1.5rem;
composes: freshnessNote from '../PeopleFreshness/styles.module.css';
}

.warning {
Expand Down
3 changes: 3 additions & 0 deletions src/components/PeopleFreshness/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/* Composed into GroupLinkStatus.module.css's own `.freshnessNote`
(`composes: freshnessNote from '../PeopleFreshness/styles.module.css'`) --
keep both freshness-note styles in sync here. */
.freshnessNote {
color: var(--ifm-color-emphasis-700);
font-size: 0.85rem;
Expand Down
Loading