Skip to content

test(coverage): ratchet the per-file harness region floor 93 -> 97 #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrbobbytables merged 1 commit into from
Oct 10, 2026
Merged

test(coverage): ratchet the per-file harness region floor 93 -> 97 #1250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"pr-queue-hygiene": "node scripts/pr-queue-hygiene.mjs",
"test:unit": "TZ=UTC node --test",
"test:unit:coverage": "TZ=UTC node tests/tools/coverage-report.mjs",
"test:unit:coverage:check": "TZ=UTC node tests/tools/coverage-report.mjs --check 99 --check-source 100 --check-regions 95 --check-source-regions 99 --check-source-file-regions 97 --check-harness 100 --check-harness-regions 97 --check-harness-file-regions 93 --require-source-files",
"test:unit:coverage:check": "TZ=UTC node tests/tools/coverage-report.mjs --check 99 --check-source 100 --check-regions 95 --check-source-regions 99 --check-source-file-regions 97 --check-harness 100 --check-harness-regions 97 --check-harness-file-regions 97 --require-source-files",
"test:e2e": "playwright test",
"build:e2e:coverage": "npm run build:e2e:coverage:site && npm run build:e2e:coverage:fixtures",
"build:e2e:coverage:site": "DOCUSAURUS_NO_PERSISTENT_CACHE=1 E2E_COVERAGE=1 npm run build:production",
Expand Down
8 changes: 4 additions & 4 deletions tests/coverage-gate-thresholds.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ const FLOORS = {
// entered none of the ratios above, which are all built from
// isSourceFile(). These are the same three shapes over its own row.
// Measured on the suite this commit ships: harness files 100.00% lines /
// 97.95% regions (3522/3522 lines, 1384/1413 regions), and the lowest
// harness file is tests/tools/e2e-coverage-report.mjs at 93.65%, floored
// to 93.
// 99.19% regions (3890/3890 lines, 1467/1479 regions), and the lowest
// harness file is tests/tools/e2e-coverage-report.mjs at 97.57%, floored
// to 97. Every other harness file is at 100.00%.
'--check-harness': 100,
'--check-harness-regions': 97,
'--check-harness-file-regions': 93,
'--check-harness-file-regions': 97,
};

function parseGate(command) {
Expand Down
Loading