Repository navigation
ci: upload flaky-run Playwright traces and run check:links on a schedule - #1196
Merged
mrbobbytables merged 1 commit intoOct 8, 2026
Merged
Conversation
Two workflow gaps consolidated in cncf#1188: Flaky traces (cncf#1179): playwright.config.js sets retries: 1, so a flaky spec fails, retries, passes, and the job exits 0. The trace upload step was gated on if: failure(), so the retained trace of the first failing attempt was discarded on every flaky run - CI kept no evidence of its own flakes. The step now runs under !cancelled() with if-no-files-found: ignore, so flake traces upload on green jobs and fully green runs stay quiet. check:links (cncf#1137): the gate was defined in package.json, configured by .markdown-link-check.json, guarded by tests, and run by no workflow. A new weekly check-links.yml runs it on a schedule and on demand; it stays out of the per-PR gates because it resolves outbound URLs against the live internet, where a third-party outage would fail unrelated PRs. The check:links entry leaves GATES_NOT_RUN_BY_CI, and the exemption cross-reference in issue-template-contract.test.mjs now points at the workflow instead. Closes cncf#1188 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Fix
Closes #1188 (consolidation of #1179 and #1137).
Flaky-run traces (#1179)
playwright.config.jssetsretries: 1andtrace: 'retain-on-failure', so a flaky spec's first failing attempt leaves a trace intest-results/— but the job exits 0 after the retry passes, and the upload step'sif: failure()never fires. Every flaky run's evidence was discarded; PR #1165's e2e flake earlier this week is a live example of a trace nobody could retrieve.The upload step now runs under
if: ${{ !cancelled() }}withif-no-files-found: ignore:check:links never ran (#1137)
check:linkswas defined in package.json, configured by.markdown-link-check.json, guarded bytests/markdown-link-check-config.test.mjs, and invoked by no workflow — recorded as a deliberate exemption inGATES_NOT_RUN_BY_CIbecause it resolves outbound URLs against the live internet.New
.github/workflows/check-links.ymlruns it weekly (Mondays 04:23 UTC) and onworkflow_dispatch, keeping the network out of per-PR gates while stopping link rot from accumulating unnoticed. Follows the repo's workflow contracts: SHA-pinned actions,persist-credentials: false,contents: read, timeout, concurrency group,NODE_VERSION: '22'(the Node-parity test reads it).Accordingly,
check:linksleavesGATES_NOT_RUN_BY_CI(the suite's "no recorded CI exemption names a gate a workflow already runs" test enforces this), and the exemption cross-reference comment inissue-template-contract.test.mjsnow points at the workflow.Validation
npm run test:unit— 2072 passed, 0 failed (workflow-contract suites cover the new workflow)npm run test:unit:coverage:check— passesnpx prettier --checkon all four touched files — clean