Skip to content

CI workflow gaps: flaky-run traces are never uploaded and check:links never runs (needs human: workflow edits) #1188

Description

@mrbobbytables

Consolidates #1179 and #1137 — both require edits under .github/workflows/, which the Hive contributor lane cannot push, so they should land together as one human-authored CI PR.

Scope

  1. Flaky-run trace upload ([quality] CI discards the traces of flaky Playwright runs: retries:1 exits 0, so the if: failure() trace upload never fires #1179): Playwright runs with retries: 1, so a spec that fails then passes on retry exits 0 and the if: failure() trace-upload step never fires. CI silently discards the evidence of every flaky run. Fix: upload traces on retry/flake as well (e.g. if: always() with retention limits, or detect flakes from the report and upload conditionally). A live example: the e2e job on PR test(mirror): cover mirrorArtworkUrls' non-regular-file destination arm #1165 failed on a change touching only a unit test file.

  2. check:links never runs ([quality] check:links is configured and guarded by a test, but no workflow ever runs it #1137): check:links is configured in package.json and guarded by a unit test, but no workflow invokes it. Fix: run it in CI (scheduled and/or on PRs touching content).

Completion criteria

Activity

  1. added
    qualityApproved by a Hive merger/owner for auto-merge on green CI
    ciApproved by a Hive merger/owner for auto-merge on green CI
    on Oct 8, 2026
  2. hivecommons-hive commented on Oct 8, 2026

    @hivecommons-hive
    Contributor

    What to reply

    • /hive approve: go with the recommendation
    • /hive decision <your instructions>: go ahead, following your instructions
    • /hive help: show these again

    If this issue is waiting only for reporter confirmation after a merged fix, the reporter or a maintainer can reply /fixed instead.

    Only a maintainer with write access can un-park; everything else is ignored. Full command reference: https://github.com/hivecommons/hive/blob/v5/src/docs/maintainer-commands.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciApproved by a Hive merger/owner for auto-merge on green CIneeds-humanqualityApproved by a Hive merger/owner for auto-merge on green CI

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions