Turns the Grenade Satchel into a Belt, plus related changes

[TheManWithNoHands]

About the pull request

• Adds a grenade belt that can be ID locked with the same stats as the Grenade Satchel
• Moves the code for id lock from backpack to its parent storage, allowing storage items to easily gain an ID lock using a 1 var change.
• Adds a new belt sprite for the lockable belt.
• Cleand up some redundant var's from the UPP grenade belt.

Explain why it's good for the game

The Grenade Satchel has no real reason to use the backpack slot. It holds about the same in grenades, and while it can hold bigger grenades we just dont have bigger grenades. Its only real diffrence is the ability to lock it. Wich is not worth the backpack slot. So on the belt it goes like its non lockable cousin. This should make the satchel into more then a box sitting at FOB to store your private stash.

How i did that i might have wasted my time by doing a small refactor kinda. (Idunno if that counts)
To not repeat code by having the same id lock code in bags and belts, i put it on their parent. /obj/item/storage.
I think this is the better option, being now you can slap the ID lock function on any storage with 1 var change, but i will undo that and just put it on belts if thats preferd.
I dont think its breaking any item either, i couldnt find any storage item that is messed up because of it.

Testing Photographs and Procedure

Screenshots & Videos

Changelog

🆑NHC
add: Added an ID lockable Grenade Belt
code: Moved the ID lock code from backpacks to its parent, storage
del: Removed the Grenade Satchel
imageadd: added Item and on_mob sprites for the new grenade belt
/:cl:

[kooarbiter]

does the grenade qol also work for the regular grenade belts riflemen can buy?

[TheManWithNoHands]

does the grenade qol also work for the regular grenade belts riflemen can buy?

Its for ALL grenade belts. All.. like 3 or so.

[TheManWithNoHands]

removed qol changes with grenade packs for atomization

[Detective-Google]

What is the incentive to take the normal old grenade belt instead of this one? If the only difference is that one can be locked and the other can't I don't think that really justifies it's inclusion as a separate item.

[TheManWithNoHands]

What is the incentive to take the normal old grenade belt instead of this one? If the only difference is that one can be locked and the other can't I don't think that really justifies it's inclusion as a separate item.

There aint no incentive really. Because there is not supposed to be.
This is simply a fix for the grenade satchels problem of being a grenade belt stat wise, but letting the player pay for the ID lock with a backpackslot. Thats real bad.

Grenade satchel doesnt need buffs, is already the grenade belt stat wise, so turning it into a belt is the solution that makes the most sense.
I also dont intent to make this a viable sidegrade to the belt here.
All this PR is really, is to make the grenade satchel no longer a trap for new players. And thats it.

[TheManWithNoHands]

Converting to draft for now.
Will need to remove the ID lock i added and further integrade the ID lock already present.

[TheManWithNoHands]

Closing this for now. Will take a bit for me to work on redoing this. No point keeping it open even as draft.