Update test environment to fix integration tests with nginx 1.30#305
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the integration test suite to account for behavior changes observed when running Framework X behind newer nginx:stable-alpine (nginx 1.30), particularly around Host-less requests reaching upstream and proxied CONNECT handling.
Changes:
- Added an explicit assertion that Host-less requests should be rejected (
400) (with a skip for the PHP development server behavior). - Updated existing Host/UA/Accept header test with a new skip to tolerate nginx 1.29.7+ upstream behavior changes.
- Updated proxy
CONNECTrejection test to skip nginx 1.30+ returning405instead of400, plus a minor comment wording tweak.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates the integration tests for two HTTP edge-case behaviors introduced when the
nginx:stable-alpineimage rolled forward to nginx 1.30. Both are expected interactions with how nginx now proxies to upstream and handlesCONNECT, not changes in Framework X behavior, and the tests cover them through the suite's existing per-server skip mechanism, the same way it already handles other server-specific differences.The 1.30 stable line picks up two changes from the nginx 1.29.x mainline. nginx 1.29.7 made HTTP/1.1 with keep-alive to upstream servers the default (nginx/nginx#1080, previously HTTP/1.0), so a Host-less HTTP/1.0 request now reaches the backend as HTTP/1.1, where a
Hostheader is required. nginx 1.29.3 reworkedCONNECThandling (nginx/nginx#935), so it now rejects proxiedCONNECTrequests with405 Not Allowedrather than400 Bad Request. Framework X handles both correctly, and a new assertion covers the HTTP/1.1Hostrequirement explicitly.Builds on top of #3, #46 and others