Potential fix for code scanning alert no. 106: Disabled Spring CSRF protection#3946
Draft
strehle wants to merge 1 commit into
Draft
Potential fix for code scanning alert no. 106: Disabled Spring CSRF protection#3946strehle wants to merge 1 commit into
strehle wants to merge 1 commit into
Conversation
…rotection Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses code scanning alert #106 by no longer globally disabling Spring Security CSRF protection on the rate limiting status security filter chain, allowing Spring’s default CSRF protection to apply.
Changes:
- Removed explicit
.csrf(CsrfConfigurer::disable)from theratelimitSecurity(HttpSecurity http)filter chain so CSRF is no longer disabled on that chain. - Removed the now-unused
CsrfConfigurerimport.
Comment on lines
54
to
56
| .sessionManagement(session -> session.sessionCreationPolicy(SessionCreationPolicy.STATELESS)) | ||
| .addFilterBefore(oauthWithoutResourceAuthenticationFilter.getFilter(), BasicAuthenticationFilter.class) | ||
| .anonymous(AnonymousConfigurer::disable) |
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/cloudfoundry/uaa/security/code-scanning/106
General fix: do not disable CSRF globally on this security chain. For Spring Security, the safest default is to leave CSRF enabled unless there is a tightly scoped and well-justified ignore rule.
Best fix here without broad functional redesign: remove the explicit disable call from
ratelimitSecurity(...)so Spring’s default CSRF protection remains active for this filter chain.File/region to change
server/src/main/java/org/cloudfoundry/identity/uaa/ratelimiting/beans/RateLimiterSecurityConfiguration.javaratelimitSecurity(HttpSecurity http), remove.csrf(CsrfConfigurer::disable).CsrfConfigurerimport.No new methods, classes, or dependencies are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.