Unsigned SAML logout message validation#3945
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a fallback validator to handle unsigned SAML Single Logout messages when Spring Security’s standard logout validators can’t be invoked (due to missing redirect signature parameters), while still validating key non-signature fields (issuer/destination/status).
Changes:
- Introduces
SamlUnsignedMessageValidatorto decode/parse unsigned logout requests/responses and validate issuer/destination (and status for responses). - Updates
SamlLogoutRequestValidator/SamlLogoutResponseValidatorto bypass the Spring delegate only when signature parameters are absent. - Updates/extends SAML-related tests and bumps the Spring Boot version in the Gradle version catalog.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| uaa/src/test/java/org/cloudfoundry/identity/uaa/mock/saml/SamlAuthenticationMockMvcTests.java | Refactors POST-form SAMLRequest extraction into a helper. |
| server/src/test/java/org/cloudfoundry/identity/uaa/authentication/SamlLogoutResponseValidatorTest.java | Adds/updates tests for unsigned logout response handling and delegate behavior. |
| server/src/test/java/org/cloudfoundry/identity/uaa/authentication/SamlLogoutRequestValidatorTest.java | Adds/updates tests for unsigned logout request handling and delegate behavior. |
| server/src/main/java/org/cloudfoundry/identity/uaa/authentication/SamlUnsignedMessageValidator.java | New unsigned-message validator for logout request/response non-signature checks. |
| server/src/main/java/org/cloudfoundry/identity/uaa/authentication/SamlLogoutResponseValidator.java | Adds bypass path for unsigned messages instead of calling delegate validator. |
| server/src/main/java/org/cloudfoundry/identity/uaa/authentication/SamlLogoutRequestValidator.java | Adds bypass path for unsigned messages instead of calling delegate validator. |
| gradle/libs.versions.toml | Updates the Spring Boot version reference. |
Introduce `SamlUnsignedMessageValidator` for unsigned SAML logout message validation. Decodes and validates unsigned SAML requests and responses while ensuring issuer, destination, and status are checked correctly.
e73e0d9 to
7384d52
Compare
strehle
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
SamlUnsignedMessageValidatorfor unsigned SAML logout message validation.Decodes and validates unsigned SAML requests and responses while ensuring issuer, destination, and status are checked correctly.