fix: isolate updater service test files#1644
Open
immanuwell wants to merge 1 commit intocloudflare:masterfrom
Open
fix: isolate updater service test files#1644immanuwell wants to merge 1 commit intocloudflare:masterfrom
immanuwell wants to merge 1 commit intocloudflare:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updater service tests used
filepath.Join(os.TempDir(), "test")as a shared fake binary path. If/tmp/testalready exists as a dir, the package falls over before it tests updater logic. tiny papercut, but pretty easy to hit on a dev box.This swaps it to
t.TempDir()so each test gets its own scratch file. No prod code touched.Repro
mkdir -p /tmp/test go test ./cmd/cloudflared/updaterBefore:
open /tmp/test: is a directoryAfter: updater tests pass.
Tested
go test ./...still hits localingressICMP permission failures here, unrelated to this change.