Web audio testing - #72
Merged
Merged
Conversation
iambalaam
commented
Jul 28, 2026
iambalaam
commented
Contributor
- Adds AudioContext, gainNode and testing harness from WebAudio Pitch Shifting #69
- Does not add audioWorklet or any webAudio pitchShifting
chetbox
reviewed
Jul 29, 2026
Comment on lines
-44
to
+43
| private mediaPreloader: MediaPreloader = new MediaPreloader(constructAssetUrl), | ||
| private _mediaPreloader: MediaPreloader = new MediaPreloader(constructAssetUrl), |
Contributor
There was a problem hiding this comment.
Why the underscore here? To me that usually signifies "unused".
Contributor
There was a problem hiding this comment.
Discussed this and this is just using the loose "private" semantics used elsewhere in the repo.
chetbox
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.