Conversation
claudiob
force-pushed
the
flowless
branch
2 times, most recently
from
September 20, 2026 02:23
c46cbd5 to
3a1c8f5
Compare
`flow` drew a page no part of Bootstrap names, out of three `content_for` keys a caller never passes, in ninety-four lines of rules only one product's onboarding wanted. It belongs to whoever ships that product. The two classes the builder writes went with it in name only -- `flow-fieldset` is `bh-fieldset` and `flow-field` is `bh-field`, both the form's business rather than a page's. `notices` became `toasts`, which is what it draws, leaving `toast` for the one a host hands over itself. It takes `data:` for a host marking what the page it stands on is about, and a block for one splicing a link into a message. And what a form was missing: an `aria-label` off the attribute on every control, a `file_field` Rails left undressed, `price_field` and `percentage_field` in Bootstrap's adorned control, a button that asks before it acts, and the data an element wearing a tooltip takes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flowdrew a page no part of Bootstrap names, out of threecontent_forkeys a caller never passes, in ninety-four lines of rules only one product's onboarding wanted. It belongs to whoever ships that product. The two classes the builder writes went with it in name only --flow-fieldsetisbh-fieldsetandflow-fieldisbh-field, both the form's business rather than a page's.noticesbecametoasts, which is what it draws, leavingtoastfor the one a host hands over itself. It takesdata:for a host marking what the page it stands on is about, and a block for one splicing a link into a message.And what a form was missing: an
aria-labeloff the attribute on every control, afile_fieldRails left undressed,price_fieldandpercentage_fieldin Bootstrap's adorned control, a button that asks before it acts, and the data an element wearing a tooltip takes.