Skip to content

Make breadcrumbs persist when you go up the chain. - #318

Open
Torgen wants to merge 5 commits into
cjb:masterfrom
Torgen:persistent-breadcrumbs
Open

Make breadcrumbs persist when you go up the chain.#318
Torgen wants to merge 5 commits into
cjb:masterfrom
Torgen:persistent-breadcrumbs

Conversation

@Torgen

@Torgen Torgen commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

Fixes #260

@Torgen

Torgen commented Feb 7, 2018

Copy link
Copy Markdown
Contributor Author

In this version there's a 'chat' button in the breadcrumbs for each level that has chat. It takes up a lot of space, it's weird when they all just say "chat", it takes up even more space if it says "Puzzle chat", "Round chat", etc., and it looks really weird with the icon but no label, both because rollover doesn't do anything when there's no text and because of all the empty space around it. I tried a version where I collapse the padding between the chat and the level it belongs to, but that looks weird when it's active because the padding is missing from only one side. I could try something like put "Puzzle: ${name} (spreadsheet icon) (link icon) (chat icon) Chat" in one <li> and underline the one that's currently in use.

@Torgen

Torgen commented Jan 11, 2019

Copy link
Copy Markdown
Contributor Author

The "underline the selected view" behavior described in the previous message was implemented in 81891c5, but it also depends on the puzzle/round template unification from #300, so I'll send it as a separate PR once this and that are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant