chore(deps): bump Swatinem/rust-cache from e18b497796c12c097a38f9edb9d0641fb99eee32 to f0d9c3887740aee45f6153b24b3a6b815192ec16 - #958
Conversation
Bumps [Swatinem/rust-cache](https://github.com/swatinem/rust-cache) from e18b497796c12c097a38f9edb9d0641fb99eee32 to f0d9c3887740aee45f6153b24b3a6b815192ec16. - [Release notes](https://github.com/swatinem/rust-cache/releases) - [Changelog](https://github.com/Swatinem/rust-cache/blob/master/CHANGELOG.md) - [Commits](Swatinem/rust-cache@e18b497...f0d9c38) --- updated-dependencies: - dependency-name: Swatinem/rust-cache dependency-version: f0d9c3887740aee45f6153b24b3a6b815192ec16 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
|
freshtonic
left a comment
There was a problem hiding this comment.
Requesting changes: the new pin is not a release of rust-cache — it is the master branch head.
I verified against upstream: f0d9c3887740aee45f6153b24b3a6b815192ec16 is Swatinem/rust-cache's current master tip (an internal dependabot-merge commit from 17 Aug), while the v2 tag this pin's comment claims to track dereferences to 6323deb102c322ba6fcbdcafc7e3dddab59af2b6 (= v2.9.2, the latest release, 6 Aug). So this diff pins our EQL CI (bench-eql, macro-expand-eql, test-eql — the jobs that compile the Rust workspace) to unreleased, unreviewed-by-release action code, and leaves the # v2 comment describing a ref the pin no longer matches.
The SHA is genuinely upstream (I checked), so this is hygiene rather than an active compromise — but the whole point of full-SHA pinning under this repo's supply-chain posture is that CI runs released action code and the comment tells the truth about which release. Suggested fix, all three files:
- uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2.9.2(The previous pin had the same shape — a non-tag master commit under a # v2 comment — so Dependabot is faithfully continuing an existing convention; re-pinning to the release commit with an exact-version comment is what stops it doing this on every future bump.)
Bumps Swatinem/rust-cache from e18b497796c12c097a38f9edb9d0641fb99eee32 to f0d9c3887740aee45f6153b24b3a6b815192ec16.
Changelog
Sourced from Swatinem/rust-cache's changelog.
... (truncated)
Commits
f0d9c38Merge pull request #380 from Swatinem/dependabot/github_actions/actions-8ff58...ccd9742Bump the actions group with 2 updates258712bfix: stop cleanup timestamp pruning after the first entry (#377)a45951fMerge pull request #373 from Swatinem/dependabot/github_actions/actions-420be...b882611Bump the actions group with 2 updates6323deb2.9.2b16e8d7bump rollup and rebuild3bf42acinvert target/profile check in cleanup6e5b278correctly sort and dedupe Rust versions5adc05fBump the actions group across 1 directory with 3 updates (#368)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)