chore(deps): bump github/codeql-action from 4.37.7 to 4.37.8 in the actions-minor-patch group - #957
Conversation
Bumps the actions-minor-patch group with 1 update: [github/codeql-action](https://github.com/github/codeql-action). Updates `github/codeql-action` from 4.37.7 to 4.37.8 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@v4.37.7...v4.37.8) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.37.8 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-minor-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
freshtonic
left a comment
There was a problem hiding this comment.
Approving the bump itself — v4.37.7 → v4.37.8 within the actions-minor-patch group, tag-pinned exactly as before, CI green.
But the two lines this PR touches expose a pre-existing defect that needs an urgent follow-up: this workflow never runs CodeQL analysis. Both steps use github/codeql-action/init — the step named "Perform CodeQL Analysis" included:
- name: Perform CodeQL Analysis
uses: github/codeql-action/init@v4.37.8 # should be codeql-action/analyzeThere is no analyze step anywhere in the file, so the job initializes CodeQL twice, uploads nothing, and reports green — a security scan that scans nothing, which is precisely the vacuous-guard failure mode this repo's own test suite exists to catch elsewhere. (The category: input on that step is an analyze input too, which init silently ignores.) The Security tab presumably shows no CodeQL results for as long as this workflow has existed — worth confirming, since that's the observable symptom.
Not blocking this bump because the fix is a functional workflow change, not a version update, and holding the group bump hostage to it helps nobody — but it should be a same-day one-line follow-up: change the second step to github/codeql-action/analyze@v4.37.8. Happy to open it.
Bumps the actions-minor-patch group with 1 update: github/codeql-action.
Updates
github/codeql-actionfrom 4.37.7 to 4.37.8Release notes
Sourced from github/codeql-action's releases.
Changelog
Sourced from github/codeql-action's changelog.
Commits
db488ddMerge pull request #4102 from github/update-v4.37.8-9ee088e131845f5bUpdate changelog for v4.37.89ee088eMerge pull request #4080 from github/henrymercer/studious-giggle1aef003Address review feedback on overlay disk flags508b83bMerge main into overlay minimum disk feature branchd97b342Merge pull request #4098 from github/mbg/permission-error-as-configuration-error47fa622MakeEACCESaConfigurationError45693ccRefactorENOSPCcheck intoisDiskConfigurationErrorfunctionc2fd8f5Merge pull request #4081 from github/mario-campos/version-cache-to-diskc56f48eLog unexpected conditions during caching CLI outputDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions