Skip to content

Add setting to hide unread activity dot indicators#2923

Open
chagai95 wants to merge 2 commits into
cinnyapp:devfrom
chagai95:dev
Open

Add setting to hide unread activity dot indicators#2923
chagai95 wants to merge 2 commits into
cinnyapp:devfrom
chagai95:dev

Conversation

@chagai95
Copy link
Copy Markdown

@chagai95 chagai95 commented May 2, 2026

The idea is to get rid of showing those type of unread rooms and keep only the ones with the number which are a lot more reliable and important.

This is how it looks before:
image

and this is after:
image

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@chagai95 chagai95 marked this pull request as ready for review May 2, 2026 01:19
@chagai95 chagai95 marked this pull request as draft May 2, 2026 01:20
@chagai95
Copy link
Copy Markdown
Author

chagai95 commented May 2, 2026

I have read the CLA Document and I hereby sign the CLA

ajbura added a commit to cinnyapp/cla that referenced this pull request May 2, 2026
@chagai95
Copy link
Copy Markdown
Author

chagai95 commented May 2, 2026

recheck

@chagai95
Copy link
Copy Markdown
Author

chagai95 commented May 2, 2026

Here's a netlify link, if you wanted to test:
https://dev--cinny-chagai.netlify.app/home/

Rooms with unread activity but no notification count (muted rooms,
push-rule-downgraded rooms) showed a small grey dot in the room list
and kept appearing in the collapsed "unread only" nav section even
though nothing actually needed attention.

This adds a "Hide Unread Activity Dots" toggle (off by default) under
Settings › Notifications › System with three coordinated effects:

1. UnreadBadge: when the setting is on, skip rendering the dot
   entirely for rooms where count=0 and highlight=false.

2. Nav collapse filter (Direct, Home, Space): reads the same setting
   reactively — when on, the collapsed category shows only rooms with
   total>0 or highlight>0; when off, it reverts to the original
   behaviour of showing all rooms that have any unread activity.
   Toggling the setting in Settings updates the nav instantly without
   a page reload.

3. Settings UI: adds the toggle under Settings › Notifications › System.
@chagai95 chagai95 marked this pull request as ready for review May 6, 2026 23:22
@CrazyNicc
Copy link
Copy Markdown

Uhm, maybe I'm misunderstanding the purpose of this PR, but your "After" screenshot just seems to hide all the rooms that had this Unread Indicator

@chagai95
Copy link
Copy Markdown
Author

chagai95 commented May 7, 2026

@CrazyNicc thx for answering so quickly!

Yes that's exactly the point. A lot of irrelevant events trigger that unread marker and I think it makes sense to hide them for some users who get a lot of messages 🙈

Also it is shown when the room is muted I think and probably in other scenarios. There are also a lot of bugs that are related to them.

@CrazyNicc
Copy link
Copy Markdown

@chagai95 Oh, afaik muting the room also removed all the read indicators.

A lot of irrelevant events trigger that unread marker and I think it makes sense to hide them for some users who get a lot of messages

But your screenshot completely hides the rooms themselves, not just the unread markers of these rooms. Or did I miss something?

@chagai95
Copy link
Copy Markdown
Author

chagai95 commented May 7, 2026

@chagai95 Oh, afaik muting the room also removed all the read indicators.

A lot of irrelevant events trigger that unread marker and I think it makes sense to hide them for some users who get a lot of messages

But your screenshot completely hides the rooms themselves, not just the unread markers of these rooms. Or did I miss something?

It hides them from the unread view, when the section is closed (arrow not down), maybe muting the room helps with that, didn't check but I don't want to start muting all my rooms just to avoid seeing this, on fluffy chat it's not shown by default in the unread tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants