Support Nokogiri 1.6.x#9
Conversation
There was a problem hiding this comment.
Should be "~> 1.5". See http://www.benjaminfleischer.com/2013/08/21/psa-gem-versions/
There was a problem hiding this comment.
I intentionally used ~> 1.5.5. Nokogiri 1.6.x should also be included.
Do you have another suggestion to make the dependency less open-ended?
There was a problem hiding this comment.
I understand the twiddle-waka better now, and I see what you did there. I'll rebase, change the code, and update the pull request at some point.
|
+1 Would like to see this as well. |
|
bump. It appears to have failed CI, but the error doesn't seem indicative of this: Update on this? Nokogiri 1.6 would be awesome so we don't have to handle as many system dependencies (1.6 adds external library vendoring). |
| @@ -0,0 +1,22 @@ | |||
| GEM | |||
| remote: http://rubygems.org/ | |||
There was a problem hiding this comment.
✂️ gems shouldn't have the Gemfile.lock commited
| @@ -1,6 +1,6 @@ | |||
| source :gemcutter | |||
There was a problem hiding this comment.
should be source 'https://rubygems.org'. sourcing gemcutter is super old cc @qrush :)
| @@ -0,0 +1,22 @@ | |||
| GEM | |||
| remote: http://rubygems.org/ | |||
There was a problem hiding this comment.
Actually, this line should be removed and replaced with gemspec, since nokogiri is required via the gemspec.
| s.files = Dir['lib/*.rb'] + Dir['lib/*.xsd'] + Dir['lib/vast/*.rb'] + Dir['test/*.rb'] + Dir['test/examples/*.xml'] + %w(LICENSE README.rdoc) | ||
|
|
||
| s.add_dependency 'nokogiri', '~> 1.5.5' | ||
| s.add_dependency 'nokogiri', '>= 1.5.5' |
There was a problem hiding this comment.
If I understand your intention, this should be ['~> 1.5', '>= 1.5.5'] which means anything in in the 1.x series greater than 1.5.5, which will include 1.5.6, 1.6.0, etc but not 2.y
4 participants
Simple Gemfile update for Nokogiri gem. All tests pass.