chore: switch back to upstream openai sdk#313
Merged
Conversation
andreynering
added a commit
to charmbracelet/crush
that referenced
this pull request
Jul 14, 2026
* Fantasy PR: charmbracelet/fantasy#313 * Ref: openai/openai-go#556 * Ref: openai/openai-go#621 We were using our own fork with a fix for SSE comment breaking the SDK. (Only specific providers send SSE comments and were failing with it, like OpenRouter). This was fixed and now we can use upstream again.
andreynering
force-pushed
the
charm-1665-openai-sdk
branch
2 times, most recently
from
77413cf to
f966ccf
Compare
andreynering
added a commit
to charmbracelet/crush
that referenced
this pull request
Jul 14, 2026
* Fantasy PR: charmbracelet/fantasy#313 * Ref: openai/openai-go#556 * Ref: openai/openai-go#621 We were using our own fork with a fix for SSE comment breaking the SDK. (Only specific providers send SSE comments and were failing with it, like OpenRouter). This was fixed and now we can use upstream again.
* Crush PR: charmbracelet/crush#3308 * Ref: openai/openai-go#556 * Ref: openai/openai-go#621 We were using our own fork with a fix for SSE comment breaking the SDK. (Only specific providers send SSE comments and were failing with it, like OpenRouter). This was fixed and now we can use upstream again.
andreynering
force-pushed
the
charm-1665-openai-sdk
branch
from
f966ccf to
d351a03
Compare
andreynering
added a commit
to charmbracelet/crush
that referenced
this pull request
Jul 15, 2026
* Fantasy PR: charmbracelet/fantasy#313 * Ref: openai/openai-go#556 * Ref: openai/openai-go#621 We were using our own fork with a fix for SSE comment breaking the SDK. (Only specific providers send SSE comments and were failing with it, like OpenRouter). This was fixed and now we can use upstream again.
andreynering
added a commit
to charmbracelet/crush
that referenced
this pull request
Jul 15, 2026
* Fantasy PR: charmbracelet/fantasy#313 * Ref: openai/openai-go#556 * Ref: openai/openai-go#621 We were using our own fork with a fix for SSE comment breaking the SDK. (Only specific providers send SSE comments and were failing with it, like OpenRouter). This was fixed and now we can use upstream again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using our own fork with a fix for SSE comment breaking the SDK. (Only specific providers send SSE comments and were failing with it, like OpenRouter).
This was fixed and now we can use upstream again.