feat(stream): catch transport errors and retry#312
Open
taciturnaxolotl wants to merge 1 commit into
Open
Conversation
taciturnaxolotl
force-pushed
the
catch-transport-errors
branch
from
e3d1b3d to
6b137d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a provider's HTTP/2 connection resets a stream mid-response, the transport
surfaces an error like:
These are transient transport failures (the server dropped the stream etc) but they were treated as non retriable. A single flaky stream would end
the turn with an ugly, low-level error message even though retrying on a fresh
connection almost always succeeds. The existing retry path already covered
io.ErrUnexpectedEOF and incomplete-stream endings, but stream resets fell
through because they aren't an
EOF, aren't anet.Error, and carry no HTTPstatus code.
upstream crush pr charmbracelet/crush#3305