Repository navigation
chore(tutorials): go mod tidy and add regression tests - #1834
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing to keep active PRs focused on core framework issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Running
go run .intutorials/basicsortutorials/commands(as well asgo test ./...insidetutorials/) currently fails immediately with:Root Cause
tutorials/go.modwas pinned to Go 1.24.2 with outdated indirect dependencies that fell out of sync with the rootcharm.land/bubbletea/v2module (which was bumped to Go 1.26.0 in #1807). Whileexamples/go.modwas updated in commit fc707bb,tutorials/go.modwas not tidied.Solution
go mod tidyintutorials/, updating its Go directive to 1.26.0 and syncing checksums intutorials/go.sum.tutorials/basics/main_test.goandtutorials/commands/main_test.gocovering model initialization, updates, and views sotutorialspackages are continuously verified bygo test ./....Fixes #1371
Verification
cd tutorials && go test -v ./...(passes with both tests)cd tutorials/basics && go run .(runs without module error)cd tutorials/commands && go test -v .(passes)go test -race -count=1 ./...(all root package tests pass)cd examples && go test ./...(all examples compile and test cleanly)go vet ./...(passes across root, examples, and tutorials)git diff --check(clean, no trailing whitespace)