Replace strip-ansi dependency with built-in util.stripVTControlCharacters#61
Open
Jah-yee wants to merge 1 commit into
Open
Replace strip-ansi dependency with built-in util.stripVTControlCharacters#61Jah-yee wants to merge 1 commit into
Jah-yee wants to merge 1 commit into
Conversation
…ters Removes the external strip-ansi dependency in favor of Node.js's built-in util.stripVTControlCharacters API (available since v16.11.0). The package already requires Node >= 20, so there are no compatibility concerns. Fixes chalk#55
Author
|
Hi @chalk/maintainers, gentle ping - this replaces strip-ansi with a built-in util. Let me know if you'd like any changes! 🙏 |
Member
|
I will get to it when I can. This is not very urgent. |
Author
|
👋 Hi maintainers, just checking in. Let me know if there's anything I can improve! |
Author
|
Hi! Just checking in — this PR has been open for 30+ days with no review. Happy to make any adjustments if needed. Thanks! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the external
strip-ansidependency with Node.js built-inutil.stripVTControlCharactersAPI.Why
Changes
import stripAnsi from "strip-ansi"withimport {stripVTControlCharacters as stripAnsi} from "node:util"strip-ansifrom dependenciesVerification
All 54 existing tests pass with this change.
Fixes #55