[lists] Make Name, Descriptions and rest of fields o nAssets list sortable#2126
Open
ivancea wants to merge 9 commits into
Open
[lists] Make Name, Descriptions and rest of fields o nAssets list sortable#2126ivancea wants to merge 9 commits into
ivancea wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Name, Description and other asset columns weren't sortable in the asset lists (Assets, Shots, Sequences, Episodes).
Also, clicking outside the dropdowns didn't close them, which allowed to open multiple dropdowns from multiple columns, feeling like the UI was broken.
Solution
Make them sortable with a custom dropdown (Just the "Sort" option for now).
Detect outside clicks and close dropdowns.
Notes
This is my first contribution in the UI, and as a user I only used the Assets list, so tell me if there's anything wrong, either functionally or technically!