[players] Display shot frame_in numbering in the frame counter#2108
Open
frankrousseau wants to merge 1 commit into
Open
[players] Display shot frame_in numbering in the frame counter#2108frankrousseau wants to merge 1 commit into
frankrousseau wants to merge 1 commit into
Conversation
Studios number their frames like DCCs do (first frame = 1001), but the player frame counter always starts at 1. When the displayed shot carries a data.frame_in start frame, shift the playback-bar frame indicator and the progress-bar hover / handle labels so the on-screen numbers match the production numbering. The offset is presentation-only: internal frame math, seeks, annotation frame keys and emitted frame events are untouched. It is carried by an opt-in frameStart prop on PlayerPlaybackBar and VideoProgress, bound by PreviewPlayer (task page) and PlaylistPlayer; consumers that do not bind it keep the 1-based display. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
Solutions
data.frame_inmetadata: a newgetEntityFrameStarthelper reads it and the players resolve it from the store shot map (task.entity_idin PreviewPlayer, current entity in PlaylistPlayer)frameStartprop (defaultundefined) onPlayerPlaybackBar(frame indicator and total) andVideoProgress(hover frame and handle labels); internal frame math, seeks, annotation frame keys and emitted frame events are untouched, and consumers that do not bind the prop keep the 1-based display