[import] Warn before CSV update creates unmatched entities#2107
Open
frankrousseau wants to merge 1 commit into
Open
[import] Warn before CSV update creates unmatched entities#2107frankrousseau wants to merge 1 commit into
frankrousseau wants to merge 1 commit into
Conversation
When updating existing data from a CSV, lines whose names don't match any existing entity (e.g. leading zeros stripped by the spreadsheet) were silently created. The preview modal now lists the entries that will be created and requires an explicit confirmation checkbox before the import can run. The Shots and Edits pages also build the existing- entity lookup from the full cache instead of the filtered display list, mirroring the Assets fix for cgwire#927, so the check stays accurate. Fixes cgwire#771 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems
001becoming1) were silently created, polluting the production; the only signal was a subtle row-color difference in the preview table (fixes When we update data with a CSV file, if the number of digits is wrong for the shots name, it will create unwanted shots #771)Solutions
csv.getNewEntityNames()insrc/lib/csv.jsand cover it with unit testsfilteredShots/filteredEditsfrom the full entity caches instead of the filtered display lists, mirroring the Assets fix for Importing CSV only checks loaded assets if already imported #927